SW-988 change octoprint to fix version comparision #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josef-MrBeam
changed the title
Josef-MrBeam
force-pushed
the
feature/SW-988-change-octoprint-to-fix-version-comparision
branch
from
afcbdc3
to
f01742d
Compare
|
@Josef-MrBeam How about this one |
|
No, I had the same issue for the new cloud config but fixed it there with the |
ahmed-mrbeam
approved these changes
Mar 21, 2022
|
@Josef-MrBeam this is intended to be merged to Stable, right ? |
ahmed-mrbeam
pushed a commit
that referenced
this pull request
Mar 30, 2022
* remove the sensitization of the version as we need the '-xxx' part (related Octoprint PR: OctoPrint#4389) * remove the leading v that we use in Mr Beam versions so can use the semantic versioning comparison
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related Octoprint PR: OctoPrint#4389
this fixes that symantic versioning concept of -beta.1 and so on was striped out of the version number
So a update from 0.9.15 to 0.9.15-beta will not be shown as an update as it is the same (0.9.15) after the sanitisation