.NET Framework specific FileSystemStream implementation#18
Open
anders9ustafsson wants to merge 2 commits intomrbrl:masterfrom
Open
.NET Framework specific FileSystemStream implementation#18anders9ustafsson wants to merge 2 commits intomrbrl:masterfrom
anders9ustafsson wants to merge 2 commits intomrbrl:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For applicability on more platforms, I have added a .NET Framework ("desktop") specific FileSystemStream assembly to allow for file system located configuration files in .NET Framework applications as well.
For this to work in .NET Framework applications, the configuration file needs to be added to the application project as Content (or None) and copied to the output directory. I realize that using the App.config name in this context might interfere with the regular application configuration file. In the longer run, it might be worthwhile considering renaming the App.config file in PCLAppConfig to something else, perhaps PCLApp.config?