-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
13 changed files
with
352 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,105 @@ | ||
| ##' Retry one or more tasks. This creates a new task that copies the | ||
| ##' work of the old one. Most of the time this is transparent. We'll | ||
| ##' document this in the "advanced" vignette once it's written. | ||
| ##' | ||
| ##' This ends up being a little more complicated than ideal in order | ||
| ##' to keep things relatively fast, while keeping our usual guarantees | ||
| ##' about race conditions etc. Basically; retrying is the only way a | ||
| ##' task can move out of a terminal state but it still does not modify | ||
| ##' the existing task. Instead, we keep a separate register of | ||
| ##' whether a task has been retried or not. Each time we retry we | ||
| ##' write into this register. When you query about the status etc of | ||
| ##' a task you can then add a `follow` argument to control whether or | ||
| ##' not we check the register. We assume that you never call this in | ||
| ##' parallel; if you do then retries may be lost. You can run | ||
| ##' `task_retry(NULL)` to refresh the cached copy of the retry map if | ||
| ##' you need to. | ||
| ##' | ||
| ##' @title Retry a task | ||
| ##' | ||
| ##' @param id The identifier or identifiers of tasks to retry. | ||
| ##' | ||
| ##' @inheritParams task_create_explicit | ||
| ##' | ||
| ##' @return export | ||
| ##' @return New identifiers for the retried tasks | ||
| task_retry <- function(id, submit = NULL, root = NULL) { | ||
| root <- hipercow_root(root) | ||
| id_real <- follow_retry_map(id, root) | ||
| status <- task_status(id_real, follow = FALSE, root) | ||
| err <- !(status %in% c("success", "failure", "cancelled")) | ||
| if (any(err)) { | ||
| n <- sum(err) | ||
| i <- utils::head(which(err), 5) | ||
| details <- set_names(sprintf("%s: %s", id_real[i], status[i]), "x") | ||
| if (length(i) < n) { | ||
| details <- c(details, c(i = "...and {n - length(i)} other task{?s}")) | ||
| } | ||
| cli::cli_abort(c("{n} {?task does/tasks do} not have terminal status", | ||
| details)) | ||
| } | ||
| id_base <- base_retry_map(id_real, root) | ||
| id_new <- vcapply(seq_along(id), function(i) { | ||
| task_create(root, "retry", NULL, NULL, | ||
| parent = id_real[[i]], base = id_base[[i]]) | ||
| }) | ||
|
|
||
| update_retry_map(id_new, id_real, id_base, root) | ||
|
|
||
| task_submit_maybe(id_new, submit, root, rlang::current_env()) | ||
|
|
||
| id_new | ||
| } | ||
|
|
||
|
|
||
| read_retry_map <- function(path) { | ||
| if (file.exists(path)) { | ||
| ret <- read.csv(path, header = FALSE) | ||
| names(ret) <- c("id", "parent", "base") | ||
| ret | ||
| } else { | ||
| data.frame(id = character(), parent = character(), base = character()) | ||
| } | ||
| } | ||
|
|
||
|
|
||
| update_retry_map <- function(id, parent, base, root) { | ||
| if (length(id) > 0) { | ||
| append_lines(sprintf("%s,%s,%s", id, parent, base), | ||
| root$path$retry) | ||
| } | ||
| root$retry_map <- read_retry_map(root$path$retry) | ||
| } | ||
|
|
||
|
|
||
| ## Lots of ways to optimise this if it becomes a timesink. Probably | ||
| ## worth special case if length(id) == 1, possibly worth a lookup we | ||
| ## invalidate with each map read? | ||
| follow_retry_map <- function(id, root) { | ||
| map <- root$retry_map | ||
| if (nrow(map) == 0 || length(id) == 0) { | ||
| ## If noone has done a retry, early exit here | ||
| return(id) | ||
| } | ||
|
|
||
| ret <- id | ||
| while (!all(is.na(id))) { | ||
| id <- map$id[match(id, map$parent)] | ||
| i <- !is.na(id) | ||
| ret[i] <- id[i] | ||
| } | ||
| ret | ||
| } | ||
|
|
||
|
|
||
| base_retry_map <- function(id, root) { | ||
| map <- root$retry_map | ||
| if (nrow(map) == 0 || length(id) == 0) { | ||
| return(id) | ||
| } | ||
| i <- match(id, map$id) | ||
| ret <- map$base[i] | ||
| j <- is.na(i) | ||
| ret[j] <- id[j] | ||
| ret | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.