Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore function args when analysing expressions #149

Merged
merged 6 commits into from
Nov 23, 2024
Merged

Ignore function args when analysing expressions #149

merged 6 commits into from
Nov 23, 2024

Conversation

richfitz
Copy link
Member

This PR changes how we analyse expressions, preventing the first case in the original ticket failing:

> id <- task_create_expr(
  expr = parallel::clusterApply(NULL, 1:2, function(x) {print(x)}),
  parallel = hipercow_parallel("parallel"),
  resources = resources)

Error in `rlang::env_get_list()`:
! Can't find `x` in environment.

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a924354) to head (25d5b2e).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #149   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines         2411      2429   +18     
=========================================
+ Hits          2411      2429   +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@richfitz richfitz marked this pull request as ready for review November 22, 2024 18:24
@weshinsley weshinsley merged commit a8cace1 into main Nov 23, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants