Rewrite WebSecurityConfig to use the lambda DSL. #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spring Security has two forms of DSLs for configuring the HttpSecurity object, one based on method chaining and [one based on lambdas][lambda-dsl]. The latter is generally more readable, as it makes it clear the scope of each configuration block. In fact the method chaining syntax is deprecated in Spring Security 6.2, and [will be removed in 7.0][migration]. We were using an inconsistent mix of the two. This cleans it up and uses the lambda DSL throughout. The only exception to this is the `AuthenticationManager` configuration, which [for some reason doesn't have a lambda DSL][sec13003] [lambda-dsl]: https://spring.io/blog/2019/11/21/spring-security-lambda-dsl [migration]: https://docs.spring.io/spring-security/reference/migration-7/configuration.html [sec13003]: spring-projects/spring-security#13003
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #134 +/- ##
=======================================
Coverage 96.91% 96.91%
=======================================
Files 125 125
Lines 1166 1166
Branches 319 319
=======================================
Hits 1130 1130
Misses 34 34
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
absternator
approved these changes
Sep 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spring Security has two forms of DSLs for configuring the HttpSecurity object, one based on method chaining and one based on lambdas. The latter is generally more readable, as it makes it clear the scope of each configuration block. In fact the method chaining syntax is deprecated in Spring Security 6.2, and will be removed in 7.0.
We were using an inconsistent mix of the two. This cleans it up and uses the lambda DSL throughout. The only exception to this is the
AuthenticationManagerconfiguration, which for some reason doesn't have a lambda DSL