Mrc-5901 Fix Excepion handling packit

[absternator]

The following PR fixes multiple issues to do with exception handling. The following are fixed:

1. If incorrect method passed for route (eg POST for /hello but we don't have)
2. if route not found 404
3. catches and throws exceptions from exceptionhandler caught in filters
4. When packitException thrown and no key found in error bundle

Testing:

1. try route that is not found eg. /random
2. try wrong HTTP type eg. POST for /packets
3. try messing with bearer token to get bearer token errors
4. Passin in auth header but don't add 'Bearer' first

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.22%. Comparing base (6ad0ede) to head (411cc93).

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #135   +/-   ##
=======================================
  Coverage   97.22%   97.22%           
=======================================
  Files         131      131           
  Lines        1225     1225           
  Branches      339      339           
=======================================
  Hits         1191     1191           
  Misses         33       33           
  Partials        1        1           

Flag	Coverage Δ
	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[plietar]

Just two notes, feel free to fix them or do them later or not at all. Happy to merge as it is.

[plietar]

Do we need this? I didn't think the api server had any concept of logout, the client just throws away their JWT.

[absternator]

yeah its so that any errors caught in filters can be caught be ExceptionHandler... eg. tokenAuthentication.... i just decided to place this filter before LogoutFilter because it is called quite early in the filter chain

[plietar]

It seems to me that this operation should return a 403 permission denied, not a 401.

403 is if the request has valid credentials, but they don't have the right scopes.
401 is if the request doesn't have credentials at all, or they are invalid.

Presumably this applies to all our endpoints.

I'm not too hung up about fixing it now, but I think we should eventually.

[absternator]

oh yip that is true.. yip will make a ticket for this