Update to new orderly.runner interface. #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #159 +/- ##
==========================================
+ Coverage 97.18% 97.20% +0.01%
==========================================
Files 149 149
Lines 1422 1432 +10
Branches 406 415 +9
==========================================
+ Hits 1382 1392 +10
Misses 39 39
Partials 1 1 ☔ View full report in Codecov by Sentry. |
plietar
force-pushed
the
mrc-6122
branch
6 times, most recently
from
50cfdf5 to
d14a8f9
Compare
M-Kusumgar
reviewed
Feb 3, 2025
app/src/app/components/contents/runner/run/PacketRunPacketGroupFields.tsx
Outdated
Show resolved
Hide resolved
|
ps: do you need to add location to the submit thing to get the tests passing? |
I'm not sure, it is working locally ... There's an error happening in the runner, and unfortunately those errors don't actually get logged: https://mrc-ide.myjetbrains.com/youtrack/issue/mrc-6152 |
The new runner does not share an on-disk repository with outpack server anymore. Instead it uses it supports an arbitrary number of repositories, and each request needs to provide the repository URL. For now, a most one Git repository can configured in the application properties. In the future, we may expand this to multiple repositories, or even allow them to be configured from the frontend and stored in the database. When submitting a run request, we also need to provide details of the outpack location. We use the same URL to outpack_server that Packit uses itself. For now at least, Packit, outpack_server and the runner workers all run on the same machine. In the future, we may make it so that the runner workers communicate via Packit, and add an authentication mechanism.
Co-authored-by: M-Kusumgar <98405247+M-Kusumgar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new runner does not share an on-disk repository with outpack server anymore. Instead it uses it supports an arbitrary number of repositories, and each request needs to provide the repository URL.
For now, a most one Git repository can configured in the application properties. In the future, we may expand this to multiple repositories, or even allow them to be configured from the frontend and stored in the database.
When submitting a run request, we also need to provide details of the outpack location. We use the same URL to outpack_server that Packit uses itself. For now at least, Packit, outpack_server and the runner workers all run on the same machine. In the future, we may make it so that the runner workers communicate via Packit, and add an authentication mechanism.