test fix and lint

app/static/src/app/components/run/RunTab.vue

@@ -108,7 +108,9 @@ export default defineComponent({
         const canDownloadOutput = computed(() => !updateMsg.value && store.state.run.resultOde?.solution);
         const toggleShowDownloadOutput = (show: boolean) => { showDownloadOutput.value = show; };
 
-        const download = (payload: {fileName: string, points: number}) => store.dispatch(`run/${RunAction.DownloadOutput}`, payload);
+        const download = (payload: {fileName: string, points: number}) => store.dispatch(
+            `run/${RunAction.DownloadOutput}`, payload
+        );
 
         return {
             canRunModel,

app/static/src/app/components/sensitivity/SensitivitySummaryPlot.vue

@@ -12,18 +12,22 @@
 
 <script lang="ts">
 
-import {computed, defineComponent, onMounted, onUnmounted, ref, watch} from "vue";
-import {AxisType, newPlot, Plots} from "plotly.js-basic-dist-min";
-import {useStore} from "vuex";
-import {config, fadePlotStyle, filterSeriesSet, margin, odinToPlotly, updatePlotTraceName} from "../../plot";
-import {SensitivityPlotExtremePrefix, SensitivityPlotType, SensitivityScaleType} from "../../store/sensitivity/state";
-import {SensitivityMutation} from "../../store/sensitivity/mutations";
-import {Batch, OdinSeriesSet} from "../../types/responseTypes";
-import {runPlaceholderMessage} from "../../utils";
-import {RunGetter} from "../../store/run/getters";
-import {Dict} from "../../types/utilTypes";
+import {
+    computed, defineComponent, onMounted, onUnmounted, ref, watch
+} from "vue";
+import { AxisType, newPlot, Plots } from "plotly.js-basic-dist-min";
+import { useStore } from "vuex";
+import {
+    config, fadePlotStyle, filterSeriesSet, margin, odinToPlotly, updatePlotTraceName
+} from "../../plot";
+import { SensitivityPlotExtremePrefix, SensitivityPlotType, SensitivityScaleType } from "../../store/sensitivity/state";
+import { SensitivityMutation } from "../../store/sensitivity/mutations";
+import { Batch, OdinSeriesSet } from "../../types/responseTypes";
+import { runPlaceholderMessage } from "../../utils";
+import { RunGetter } from "../../store/run/getters";
+import { Dict } from "../../types/utilTypes";
 import WodinPlotDataSummary from "../WodinPlotDataSummary.vue";
-import {verifyValidPlotSettingsTime} from "./support";
+import { verifyValidPlotSettingsTime } from "./support";
 
 export default defineComponent({
     name: "SensitivitySummaryPlot",
@@ -113,10 +117,10 @@ export default defineComponent({
                     });
                     result.push(...psPlotData);
                 });
-                store.commit(`sensitivity/${SensitivityMutation.SetLoading}`, false);
+                store.commit(`${namespace}/${SensitivityMutation.SetLoading}`, false);
                 return result;
             }
-            store.commit(`sensitivity/${SensitivityMutation.SetLoading}`, false);
+            store.commit(`${namespace}/${SensitivityMutation.SetLoading}`, false);
             return [];
         });
         const hasPlotData = computed(() => !!(plotData.value?.length));

app/static/src/app/components/sensitivity/support.ts

@@ -1,9 +1,9 @@
+import { Commit } from "vuex";
 import { SensitivityUpdateRequiredReasons } from "../../store/sensitivity/state";
 import userMessages from "../../userMessages";
 import { appendIf, joinStringsSentence } from "../../utils";
-import {SensitivityMutation} from "../../store/sensitivity/mutations";
-import {AppState} from "../../store/appState/state";
-import {Commit} from "vuex";
+import { SensitivityMutation } from "../../store/sensitivity/mutations";
+import { AppState } from "../../store/appState/state";
 
 export const sensitivityUpdateRequiredExplanation = (reasons: SensitivityUpdateRequiredReasons): string => {
     const explanation: string[] = [];

app/static/src/app/excel/wodinModelOutputDownload.ts

@@ -43,7 +43,8 @@ export class WodinModelOutputDownload extends WodinExcelDownload {
             const { selectedVariables } = this._state.model;
 
             const worksheet = WodinModelOutputDownload._generateModelledOutput(
-                selectedVariables, solutionOutput, [], null);
+                selectedVariables, solutionOutput, [], null
+            );
             XLSX.utils.book_append_sheet(this._workbook, worksheet, "Modelled");
         }
     }

app/static/src/app/excel/wodinSensitivitySummaryDownload.ts

@@ -46,4 +46,4 @@ export class WodinSensitivitySummaryDownload extends WodinExcelDownload {
             this._addParameters([varyingParameter]);
         });
     };
-}
+}

app/static/tests/unit/components/run/runTab.test.ts

@@ -6,6 +6,7 @@ jest.mock("plotly.js-basic-dist-min", () => {});
 /* eslint-disable import/first */
 import Vuex from "vuex";
 import { shallowMount } from "@vue/test-utils";
+import { nextTick } from "vue";
 import { BasicState } from "../../../../src/app/store/basic/state";
 import {
     mockBasicState, mockModelState, mockRunState, mockStochasticState
@@ -119,7 +120,7 @@ describe("RunTab", () => {
     };
 
     it("renders as expected when can run model", () => {
-        const runState = {...defaultRunState, userDownloadFileName: "test.xlsx" }
+        const runState = { ...defaultRunState, userDownloadFileName: "test.xlsx" };
         const wrapper = getWrapper(defaultModelState, runState);
         expect(wrapper.find("button#run-btn").text()).toBe("Run model");
         expect((wrapper.find("button#run-btn").element as HTMLButtonElement).disabled).toBe(false);
@@ -255,6 +256,7 @@ describe("RunTab", () => {
         const download = wrapper.findComponent(DownloadOutput);
         expect(download.props().open).toBe(true);
         download.vm.$emit("close");
+        await nextTick();
         expect(download.props().open).toBe(false);
     });
 

app/static/tests/unit/components/sensitivity/sensitivityTab.test.ts

@@ -1,20 +1,20 @@
-import {mount} from "@vue/test-utils";
+import { mount } from "@vue/test-utils";
 import Vuex from "vuex";
-import {ModelState} from "../../../../src/app/store/model/state";
+import { nextTick } from "vue";
+import { ModelState } from "../../../../src/app/store/model/state";
 import SensitivityTab from "../../../../src/app/components/sensitivity/SensitivityTab.vue";
 import ActionRequiredMessage from "../../../../src/app/components/ActionRequiredMessage.vue";
-import {SensitivityGetter} from "../../../../src/app/store/sensitivity/getters";
+import { SensitivityGetter } from "../../../../src/app/store/sensitivity/getters";
 import SensitivityTracesPlot from "../../../../src/app/components/sensitivity/SensitivityTracesPlot.vue";
-import {SensitivityPlotType, SensitivityState} from "../../../../src/app/store/sensitivity/state";
-import {SensitivityAction} from "../../../../src/app/store/sensitivity/actions";
+import { SensitivityPlotType, SensitivityState } from "../../../../src/app/store/sensitivity/state";
+import { SensitivityAction } from "../../../../src/app/store/sensitivity/actions";
 import SensitivitySummaryPlot from "../../../../src/app/components/sensitivity/SensitivitySummaryPlot.vue";
 import ErrorInfo from "../../../../src/app/components/ErrorInfo.vue";
-import {AppState, AppType} from "../../../../src/app/store/appState/state";
-import {ModelGetter} from "../../../../src/app/store/model/getters";
+import { AppState, AppType } from "../../../../src/app/store/appState/state";
+import { ModelGetter } from "../../../../src/app/store/model/getters";
 import LoadingSpinner from "../../../../src/app/components/LoadingSpinner.vue";
-import {SensitivityMutation} from "../../../../src/app/store/sensitivity/mutations";
+import { SensitivityMutation } from "../../../../src/app/store/sensitivity/mutations";
 import DownloadOutput from "../../../../src/app/components/DownloadOutput.vue";
-import {nextTick} from "vue";
 
 jest.mock("plotly.js-basic-dist-min", () => {});
 
@@ -169,7 +169,7 @@ describe("SensitivityTab", () => {
         const enabledResult = {
             inputs: {},
             batch: {
-                solutions: [ "test solution" ] as any,
+                solutions: ["test solution"] as any,
                 errors: []
             },
             error: null
@@ -187,13 +187,13 @@ describe("SensitivityTab", () => {
         // disabled if update required
         expectDownloadButtonEnabled({
             ...enabledState,
-            sensitivityUpdateRequired: { modelChanged: true}
+            sensitivityUpdateRequired: { modelChanged: true }
         }, false);
 
         // disabled if no batch result
         expectDownloadButtonEnabled({
             ...enabledState,
-            result: {...enabledResult, batch: null}
+            result: { ...enabledResult, batch: null }
         }, false);
     });
 

app/static/tests/unit/components/sensitivity/support.test.ts

@@ -2,8 +2,8 @@ import {
     sensitivityUpdateRequiredExplanation,
     verifyValidPlotSettingsTime
 } from "../../../../src/app/components/sensitivity/support";
-import {mockBasicState, mockRunState, mockSensitivityState} from "../../../mocks";
-import {SensitivityMutation} from "../../../../src/app/store/sensitivity/mutations";
+import { mockBasicState, mockRunState, mockSensitivityState } from "../../../mocks";
+import { SensitivityMutation } from "../../../../src/app/store/sensitivity/mutations";
 
 describe("construct actionable fit update messages from fit state changes", () => {
     const base = {

app/static/tests/unit/excel/mocks.ts

@@ -14,4 +14,4 @@ jest.mock("xlsx", () => ({
         book_new: () => mockBookNew(),
         book_append_sheet: (wb: any, ws: any, name: string) => mockBookAppendSheet(wb, ws, name)
     }
-}));
+}));

app/static/tests/unit/serialiser.test.ts

@@ -123,6 +123,8 @@ describe("serialise", () => {
     const sensitivityState = {
         running: true,
         loading: false,
+        downloading: false,
+        userSummaryDownloadFileName: "",
         paramSettings: {
             parameterToVary: "alpha",
             scaleType: SensitivityScaleType.Arithmetic,