mrc-5953 vitest pt 2 #220
Merged
mrc-5953 vitest pt 2 #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaLRussell
reviewed
Nov 7, 2024
| @@ -276,7 +275,7 @@ describe("RunPlot", () => { | |||
| fadePlot: false, | |||
| graphIndex: 0, | |||
| graphConfig | |||
| }, | |||
| } as any, | |||
There was a problem hiding this comment.
Why do you need these as anys - is this not providing all the props the RunPlot expects? I suppose could spread an empty props object here if so, but probably not worth it!
There was a problem hiding this comment.
linkedXAxis was the issue in this one! yh just thought it wasnt worth it to add it cos we dont use linkedXAxis in most of these tests
| @@ -95,7 +94,7 @@ describe("RunPlot for stochastic", () => { | |||
|
|
|||
| // Generates expected plot data from model | |||
| const plotData = wodinPlot.props("plotData"); | |||
| const data = plotData(); | |||
| const data = plotData(0, 0, 0); | |||
There was a problem hiding this comment.
What's going on with this change?
There was a problem hiding this comment.
so WodinPlot.vue specifies the prop plotData as type (number, number, number) => WodinPlotData and it was giving typescript errors because we didnt put 3 args in it even though it doesnt matter but yh technically typescript is correct
EmmaLRussell
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i dont think this one has anything super different from the old one, just more of those systematic changes, making sure types and function signatures match!