mrc-5955 vitest pt 4 #222
Merged
mrc-5955 vitest pt 4 #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EmmaLRussell
reviewed
Nov 7, 2024
Comment on lines
+374
to
+385
| const checkbox = wrapper.find("input#show-unlabelled-check"); | ||
| (checkbox.element as HTMLInputElement).checked = false; | ||
| await checkbox.trigger("change"); | ||
| expect(mockSaveUserPreferences).toHaveBeenCalledTimes(1); | ||
| expect(mockSaveUserPreferences.mock.calls[0][1]).toStrictEqual({ showUnlabelledSessions: false }); | ||
| }); | ||
|
|
||
| it("can save show duplicate sessions preference", async () => { | ||
| const wrapper = getWrapper({ sessionsMetadata }, currentSessionId); | ||
| await wrapper.find("input#show-duplicates-check").trigger("click"); | ||
| const checkbox = wrapper.find("input#show-duplicates-check"); | ||
| (checkbox.element as HTMLInputElement).checked = true; | ||
| await checkbox.trigger("change"); |
There was a problem hiding this comment.
in the last PR you used the "input" event for checkboxes I think - could you do the same here?
There was a problem hiding this comment.
ahh so this one was actually a bit weird, basically because we are using a v-model in the component and in the last PR the component i was testing was using an explicit event like @input or @change, v-model works in a slightly different way, it requires a change event to trigger
EmmaLRussell
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
same stuff here but
getMockResultwas introduced because redraw watches now also watch the result so need that in the test!