Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrc-5956 vitest pt 5 #223

Merged
merged 1 commit into from
Nov 13, 2024
Merged

mrc-5956 vitest pt 5 #223

merged 1 commit into from
Nov 13, 2024

Conversation

M-Kusumgar
Copy link
Collaborator

@M-Kusumgar M-Kusumgar commented Nov 5, 2024

i could not find a way to injecting in mockPlotDataFn how it originally was in the wrapper, it kept not returning the correct thing, so i just set it as a prop after creating the wrapper in wodinPlot.test.ts thought it was an alright way to do it

@M-Kusumgar M-Kusumgar changed the title batch of tests mrc-5956 vitest pt 5 Nov 6, 2024
Copy link
Contributor

@EmmaLRussell EmmaLRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@M-Kusumgar M-Kusumgar changed the base branch from mrc-5955 to mrc-5945 November 13, 2024 20:29
@M-Kusumgar M-Kusumgar merged commit 5272125 into mrc-5945 Nov 13, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants