Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mrc-5958 vitest pt 7 #225

Merged
merged 1 commit into from
Nov 13, 2024
Merged

mrc-5958 vitest pt 7 #225

merged 1 commit into from
Nov 13, 2024

Conversation

M-Kusumgar
Copy link
Collaborator

@M-Kusumgar M-Kusumgar commented Nov 5, 2024

i have created a baseSensitivity test file that only tests those, this used to live in the senstivity test file which was causing it to run twice for some reason and the test was very flaky, but now the test only runs once and it is probably better if it has its own file anyway

@M-Kusumgar M-Kusumgar changed the title store tests mrc-5958 vitest pt 7 Nov 6, 2024
Copy link
Contributor

@EmmaLRussell EmmaLRussell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't really see why it would have been running twice!. Is the file imported somewhere else or something. But yeah, seems good to have it in a separate module anyway!

@M-Kusumgar
Copy link
Collaborator Author

Don't really see why it would have been running twice!. Is the file imported somewhere else or something. But yeah, seems good to have it in a separate module anyway!

i have no idea but my guess was because sensitivity tests were also exporting the run common tests function and the multisensitivity tests were importing it? but then no idea why only the base ones ran twice and not the sensitivity tests

@M-Kusumgar M-Kusumgar changed the base branch from mrc-5957 to mrc-5945 November 13, 2024 20:30
@M-Kusumgar M-Kusumgar merged commit b9d451d into mrc-5945 Nov 13, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants