Skip to content

Commit

Permalink
drm/amd/display: readd -msse2 to prevent Clang from emitting libcalls…
Browse files Browse the repository at this point in the history
… to undefined SW FP routines

[ Upstream commit 0f0727d ]

arch/x86/Makefile disables SSE and SSE2 for the whole kernel.  The
AMDGPU drivers modified in this patch re-enable SSE but not SSE2.  Turn
on SSE2 to support emitting double precision floating point instructions
rather than calls to non-existent (usually available from gcc_s or
compiler_rt) floating point helper routines for Clang.

This was originally landed in:
commit 1011745 ("drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines")
but reverted in:
commit 193392e ("Revert "drm/amd/display: add -msse2 to prevent Clang from emitting libcalls to undefined SW FP routines"")
due to bugreports from GCC builds. Add guards to only do so for Clang.

Link: https://bugs.freedesktop.org/show_bug.cgi?id=109487
Link: ClangBuiltLinux#327

Suggested-by: Sedat Dilek <sedat.dilek@gmail.com>
Suggested-by: Sami Tolvanen <samitolvanen@google.com>
Signed-off-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
  • Loading branch information
nickdesaulniers authored and gregkh committed Sep 29, 2019
1 parent 3bf50e1 commit 90e5eb5
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 0 deletions.
4 changes: 4 additions & 0 deletions drivers/gpu/drm/amd/display/dc/calcs/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ endif

calcs_ccflags := -mhard-float -msse $(cc_stack_align)

ifdef CONFIG_CC_IS_CLANG
calcs_ccflags += -msse2
endif

CFLAGS_dcn_calcs.o := $(calcs_ccflags)
CFLAGS_dcn_calc_auto.o := $(calcs_ccflags)
CFLAGS_dcn_calc_math.o := $(calcs_ccflags) -Wno-tautological-compare
Expand Down
4 changes: 4 additions & 0 deletions drivers/gpu/drm/amd/display/dc/dml/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,10 @@ endif

dml_ccflags := -mhard-float -msse $(cc_stack_align)

ifdef CONFIG_CC_IS_CLANG
dml_ccflags += -msse2
endif

CFLAGS_display_mode_lib.o := $(dml_ccflags)
CFLAGS_display_pipe_clocks.o := $(dml_ccflags)
CFLAGS_dml1_display_rq_dlg_calc.o := $(dml_ccflags)
Expand Down

0 comments on commit 90e5eb5

Please sign in to comment.