fix(config): Could not find an executable binary on windows #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review ChecklistDoes this PR follow the Contribution Guidelines? Following is a partial checklist: Proper conventional commit scoping:
If applicable:
|
mrcjkb
requested changes
Jan 23, 2025
lua/rustaceanvim/config/internal.lua
Outdated
| @@ -283,7 +283,7 @@ local RustaceanDefaultConfig = { | |||
| end, | |||
| ---@type string[] | fun():(string[]|fun(dispatchers: vim.lsp.rpc.Dispatchers): vim.lsp.rpc.PublicClient) | |||
| cmd = function() | |||
| return { 'rust-analyzer', '--log-file', RustaceanConfig.server.logfile } | |||
| return { vim.fn.exepath('rust-analyzer'), '--log-file', RustaceanConfig.server.logfile } | |||
There was a problem hiding this comment.
issue: vim.fn.exepath can return an empty string, with would break the error message in the health check. We should fall back to 'rust-analyzer' in this case.
|
Thanks for the review, now added conditional fallback to |
mrcjkb
reviewed
Jan 23, 2025
Comment on lines
285
to
287
| cmd = function() | ||
| return { 'rust-analyzer', '--log-file', RustaceanConfig.server.logfile } | ||
| return { vim.fn.exepath('rust-analyzer') or 'rust-analyzer', '--log-file', RustaceanConfig.server.logfile } | ||
| end, |
There was a problem hiding this comment.
issue: This won't work.
I've implemented a fix in #665.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #663