feat: Added IsInteger method in Fixed64.cs and Fixed64.Extensions.cs #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
it’s a solid, efficient implementation of integer detection for fixed-point numbers. nice job and thank you for the contribution, glad to see other folks are finding the library useful! |
mrdav30
added a commit
that referenced
this pull request
Feb 17, 2025
* refactor: seperate unity package into new project * task: update readme * feat: Added IsInteger method in Fixed64.cs and Fixed64.Extensions.cs (#21) * feat: Added IsInteger method in Fixed64.cs and Fixed64.Extensions.cs * fix: using MAX_SHIFTED_AMOUNT_UI instead of uint.MaxValue --------- Co-authored-by: Lucas S. Tomazetto <145228338+ltomazetto@users.noreply.github.com>
mrdav30
added a commit
that referenced
this pull request
Feb 17, 2025
* refactor: unity integration (#16) * task: refactor handling of Unity integration * task: bump gitversion/setup to v3.1.1 * ci: update dotnet.yml * fix: dotnet build configuration * fix: dotnet project build configurations * task: update readme * task: support for dotnet v8 (#19) * task: support for dotnet v8 * task: bump artifact actions version * Refactor/unity package (#22) * refactor: seperate unity package into new project * task: update readme * feat: Added IsInteger method in Fixed64.cs and Fixed64.Extensions.cs (#21) * feat: Added IsInteger method in Fixed64.cs and Fixed64.Extensions.cs * fix: using MAX_SHIFTED_AMOUNT_UI instead of uint.MaxValue --------- Co-authored-by: Lucas S. Tomazetto <145228338+ltomazetto@users.noreply.github.com> --------- Co-authored-by: Lucas S. Tomazetto <145228338+ltomazetto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I would like to contribute to this pull request where I implemented a method to check if a Fixed64 is an integer. I was recently using your library in a project and came across this need, I thought it would be a good idea to share the solution.