Skip to content

Commit

Permalink
KTX2Loader: Support transcoding UASTC HDR to BC6H and RGBA16 (#29730)
Browse files Browse the repository at this point in the history
* KTX2Loader: Support transcoding UASTC HDR to BC6H and RGBA16
* GLTFLoader: Fix incorrect texture.generateMipmaps setting
  • Loading branch information
donmccurdy authored Oct 24, 2024
1 parent 4e6f914 commit 35adad2
Show file tree
Hide file tree
Showing 4 changed files with 143 additions and 48 deletions.
2 changes: 1 addition & 1 deletion examples/jsm/loaders/GLTFLoader.js
Original file line number Diff line number Diff line change
Expand Up @@ -3230,7 +3230,7 @@ class GLTFParser {
texture.minFilter = WEBGL_FILTERS[ sampler.minFilter ] || LinearMipmapLinearFilter;
texture.wrapS = WEBGL_WRAPPINGS[ sampler.wrapS ] || RepeatWrapping;
texture.wrapT = WEBGL_WRAPPINGS[ sampler.wrapT ] || RepeatWrapping;
texture.generateMipmaps = texture.minFilter !== NearestFilter && texture.minFilter !== LinearFilter;
texture.generateMipmaps = ! texture.isCompressedTexture && texture.minFilter !== NearestFilter && texture.minFilter !== LinearFilter;

parser.associations.set( texture, { textures: textureIndex } );

Expand Down
Loading

0 comments on commit 35adad2

Please sign in to comment.