RenderObject: Fix material cache key regression.

mrdoob · Jul 22, 2024 · 76887ef · 76887ef
1 parent 4755144
commit 76887ef
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/src/renderers/common/RenderObject.js b/src/renderers/common/RenderObject.js
@@ -195,14 +195,19 @@ export default class RenderObject {
 
 			const value = material[ property ];
 
-			let valueKey;
+			let valueKey = value;
 
-			if ( value !== null ) {
+			if ( value ) {
+
+				// some material values require a formatting
 
 				const type = typeof value;
 
-				if ( type === 'number' ) valueKey = value !== 0 ? '1' : '0'; // Convert to on/off, important for clearcoat, transmission, etc
-				else if ( type === 'object' ) {
+				if ( type === 'number' ) {
+
+					valueKey = value !== 0 ? '1' : '0'; // Convert to on/off, important for clearcoat, transmission, etc
+
+				} else if ( type === 'object' ) {
 
 					valueKey = '{';
 
@@ -216,10 +221,6 @@ export default class RenderObject {
 
 				}
 
-			} else {
-
-				valueKey = String( value );
-
 			}
 
 			cacheKey += /*property + ':' +*/ valueKey + ',';