Skip to content

Commit

Permalink
WebGPUUniform: Don't override value with null
Browse files Browse the repository at this point in the history
  • Loading branch information
takahirox authored Sep 21, 2020
1 parent 271a103 commit b7c038d
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions examples/jsm/renderers/webgpu/WebGPUUniform.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,13 @@ import { Color, Matrix3, Matrix4, Vector2, Vector3, Vector4 } from '../../../../

class WebGPUUniform {

constructor( name, value ) {
constructor( name, value = null ) {

this.name = name;
this.value = value;

this.byteLength = 0;
this.itemSize = 0;
this.value = null;

This comment has been minimized.

Copy link
@takahirox

takahirox Sep 21, 2020

Author Collaborator

Sorry, I was going to make PR but I have directly pushed a commit by my misoperation.

I don't think this.value should be overridden with null here. Does this change look good?

This comment has been minimized.

Copy link
@Mugen87

Mugen87 Sep 21, 2020

Collaborator

Yes, this looks fine!


}

Expand Down

0 comments on commit b7c038d

Please sign in to comment.