fileMap should exist when parsing (#23097)

* fileMap should exist when parsing * always set fileMap to new Object()
mrdoob · Dec 28, 2021 · fbd067f · fbd067f
1 parent 5169da8
commit fbd067f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/editor/js/Loader.js b/editor/js/Loader.js
@@ -392,7 +392,6 @@ function Loader( editor ) {
 					var { LDrawLoader } = await import( '../../examples/jsm/loaders/LDrawLoader.js' );
 
 					var loader = new LDrawLoader();
-					loader.fileMap = {}; // TODO Uh...
 					loader.setPath( '../../examples/models/ldraw/officialLibrary/' );
 					loader.parse( event.target.result, undefined, function ( group ) {
 

diff --git a/examples/jsm/loaders/LDrawLoader.js b/examples/jsm/loaders/LDrawLoader.js
@@ -815,7 +815,7 @@ class LDrawLoader extends Loader {
 		this.cache = new LDrawFileCache( this );
 
 		// This object is a map from file names to paths. It agilizes the paths search. If it is not set then files will be searched by trial and error.
-		this.fileMap = null;
+		this.fileMap = {};
 
 		this.rootParseScope = this.newParseScopeLevel();
 
@@ -874,12 +874,6 @@ class LDrawLoader extends Loader {
 
 	load( url, onLoad, onProgress, onError ) {
 
-		if ( ! this.fileMap ) {
-
-			this.fileMap = {};
-
-		}
-
 		const fileLoader = new FileLoader( this.manager );
 		fileLoader.setPath( this.path );
 		fileLoader.setRequestHeader( this.requestHeader );