-
-
Notifications
You must be signed in to change notification settings - Fork 35.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misleading Documentation - Matrix4 #13183
Labels
Comments
Good find! Indeed, the sentence |
You mean with a pull request? I can try to do that. |
Yes please 👍 |
miguelriemoliveira
added a commit
to miguelriemoliveira/three.js
that referenced
this issue
Jan 26, 2018
miguelriemoliveira
added a commit
to miguelriemoliveira/three.js
that referenced
this issue
Jan 26, 2018
Matrix4 - description for matrix and matrixWorld items in mrdoob#13183
Made a mistake and did a pull request to my own fork first. Now its correct - a pull request is open to fix this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The description for the Matrix4 in the online documentation says:
"
Perhaps I am misunderstanding something, but the matrixWorld should store the object's transformation relative to the world. Thus the sentence "This is the object's transformation relative to its parent" seems incorrect.
I would guess this sentence was written to the matrix . I think that's the proper description for the matrix, not for the matrixWorld.
Am I getting it all wrong or is this just a typo in the documentation?
Regards,
Miguel
PS: Thanks for making THREEJS such a great tool
The text was updated successfully, but these errors were encountered: