Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misleading Documentation - Matrix4 #13183

Closed
miguelriemoliveira opened this issue Jan 26, 2018 · 5 comments
Closed

Misleading Documentation - Matrix4 #13183

miguelriemoliveira opened this issue Jan 26, 2018 · 5 comments
Labels

Comments

@miguelriemoliveira
Copy link
Contributor

The description for the Matrix4 in the online documentation says:

"

Every Object3D has three associated Matrix4s:
Object3D.matrix: This stores the local transform of the object.
Object3D.matrixWorld: The global or world transform of the object. This is the object's transformation relative to its parent. If the object has no parent, then this is identical to the local transform.
"

Perhaps I am misunderstanding something, but the matrixWorld should store the object's transformation relative to the world. Thus the sentence "This is the object's transformation relative to its parent" seems incorrect.

I would guess this sentence was written to the matrix . I think that's the proper description for the matrix, not for the matrixWorld.

Am I getting it all wrong or is this just a typo in the documentation?

Regards,

Miguel

PS: Thanks for making THREEJS such a great tool

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 26, 2018

Good find! Indeed, the sentence This is the object's transformation relative to its parent. is wrong there. It belongs to matrix. Would you like to correct the description? 😊

@miguelriemoliveira
Copy link
Contributor Author

You mean with a pull request? I can try to do that.

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 26, 2018

Yes please 👍

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 26, 2018

You can also use the "Edit" feature of github.

image

@miguelriemoliveira
Copy link
Contributor Author

Made a mistake and did a pull request to my own fork first. Now its correct - a pull request is open to fix this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants