Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additive animation does not always evaluate properly with cubic spline interpolation #20025

Closed
4 of 13 tasks
c-morten opened this issue Aug 6, 2020 · 0 comments · Fixed by #20021
Closed
4 of 13 tasks
Labels

Comments

@c-morten
Copy link

c-morten commented Aug 6, 2020

Description of the problem

When converting an AnimationClip to additive using AnimationUtils.makeClipAdditive when the clip contains animation with cubic spline interpolation, the tangent values get subtracted instead of the actual keyframe value. I submitted a PR with a fix for the issue here: #20021

To reproduce:
  • Pull the repository
  • Replace examples/models/gltf/xbot.glb with the glb from the attached zip file
    xbot.zip
  • Do npm run dev and open one of the server links
  • Navigate to the animation/skinning/additive/blending example
  • Set any of the Additive Action Weights to a non-zero value
Expected

The character blends the additive animation on top of the animations in Base Actions

Actual

The character disappears

Three.js version
  • Dev
  • r119
  • ...
Browser
  • All of them
  • Chrome
  • Firefox
  • Internet Explorer
OS
  • All of them
  • Windows
  • macOS
  • Linux
  • Android
  • iOS
Hardware Requirements (graphics card, VR Device, ...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants