Added support for tracks with cubic spline interpolation to AnimationUtils.makeClipAdditive #20021
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of this method assumes that a track's valueSize is the number of values the target property can hold (3 for vectors, 4 for quaternions, etc). However for tracks using cubic spline interpolation it is actually 3 times that length to account for in/out tangents, resulting in the in-tangent values being used for the reference value rather than the actual keyframe value. I added a check for the interpolation type and offset the reference and target indices accordingly. I also fixed a small issue in
PropertyMixer
where the quaternion buffer does not get set to a valid identity quaternion for cubic spline buffers when usingPropertyMixer._setAdditiveIdentityQuaternion
.Fixes #20025