Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDZ exporter with target wall placement #21995

Closed
ThorstenBux opened this issue Jun 16, 2021 · 2 comments · Fixed by #22854
Closed

USDZ exporter with target wall placement #21995

ThorstenBux opened this issue Jun 16, 2021 · 2 comments · Fixed by #22854

Comments

@ThorstenBux
Copy link
Contributor

Is your feature request related to a problem? Please describe.

When exporting to USDZ currently there is the possibility missing to define the tracking target for AR view (AR Quick-look)

Describe the solution you'd like

I'm thinking of a way to make the exporter configurable so that it accepts the different tracking targets supported by Apple AR Quick-look

Additional context
Reading through the schema definition here: https://developer.apple.com/documentation/arkit/usdz_schemas_for_ar
It is possible to encode into the USDZ which tracking target should be used. Hence, I've extended the USDZExporter to support configuration for targets. For now, wall target is integrated but more can be added in the future.

Please see this branch for more context.

Also, I'd like to add that this is my first approach to contribute to this amazing project. And I'm sure I need to do many rounds before this is even close to acceptable but I'd like to give it a go.

My WIP branch: https://github.com/ThorstenBux/three.js/tree/feat/wall-placement-usdz

@enzyme69
Copy link

In that case maybe we should also enable:

  • Image Marker Anchor
  • Face Anchor

Also on top of that, if we could embed Custom Shader like "Occlusion shader"?

@ThorstenBux
Copy link
Contributor Author

Sure, happy to. I'd just like to keep it small and one step after the other.
We need to agree on the options object first and then move forward with further improvements. (In my humble opinion)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants