Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USDZExporter: recent changes aren't complete and are breaking existing experiences #25011

Closed
hybridherbst opened this issue Nov 24, 2022 · 0 comments · Fixed by #25012
Closed

Comments

@hybridherbst
Copy link
Contributor

Describe the bug

Seems like #24854 and #22854 aren't quite complete, there's missing toPrecision calls for the camera values and default plane anchoring is now vertical, resulting in everything being placed on walls instead of floors by default.

I'll make a PR fixing those in a moment, but wanted to open an issue first... if this version of three goes out as-is things like model-viewer USDZ auto-conversion would be broken. cc @elalish

To Reproduce

Steps to reproduce the behavior:
On latest dev, go to the USDZ exporter sample and export the file on iOS.

Expected behavior

Same as before, object should be placed on the floor. Now it's on walls 🙃

Platform:

  • Device: [Mobile]
  • OS: [iOS]
  • Browser: [Chrome, Safari]
  • Three.js version: [dev]
hybridherbst added a commit to needle-tools/three.js that referenced this issue Nov 24, 2022
hybridherbst added a commit to needle-tools/three.js that referenced this issue Nov 24, 2022
Mugen87 pushed a commit that referenced this issue Nov 24, 2022
hybridherbst added a commit to needle-tools/three.js that referenced this issue Mar 27, 2023
… proper disposal, and animation

* added webgl_loader_multiple as example of how to load multiple files one after each other
* added bounds fitting
* added FBX import as second file type example
* added material upgrade of FBX materials to MeshStandardMaterial to receive IBL
* fix minDistance possibly being greater than maxDistance, fix animation loading and playback
* switched to animationLoop

workaround for having a nicely blurred background from the environment

alternative blur approach: use texture mipmaps directly. less pretty

clean up, add link to PR that will introduce background bluriness

fix env bluriness (harder with mipmaps), fix HDRI Haven url

update screenshot

replace blurred background hack with new backgroundBlurriness

feat: add USDZ loading, glTF export and USDZ export, FBX material conversion

USDZExporter: fix default plane anchoring orientation and add precision specifiers (mrdoob#25012)

Fixes mrdoob#25011

[XR] Feat: Allow passing GLTFLoader into OculusHandModel/XRHandMeshModel (mrdoob#25013)

* feat: allow passing GLTFLoader into OculusHandModel/XRHandMeshModel

* apply review feedback

USDZExporter: guard against missing image data in textures

USDZLoader: add hierarchy support and fix loading files exported with USDZExporter

GLTFExporter: guard against missing image data in textures

simplify null check

cleanup child name and add example for texture traversal after loading

added file input button, added download button for OBJ
hybridherbst added a commit to needle-tools/three.js that referenced this issue Mar 30, 2023
… proper disposal, and animation

* added webgl_loader_multiple as example of how to load multiple files one after each other
* added bounds fitting
* added FBX import as second file type example
* added material upgrade of FBX materials to MeshStandardMaterial to receive IBL
* fix minDistance possibly being greater than maxDistance, fix animation loading and playback
* switched to animationLoop

workaround for having a nicely blurred background from the environment

alternative blur approach: use texture mipmaps directly. less pretty

clean up, add link to PR that will introduce background bluriness

fix env bluriness (harder with mipmaps), fix HDRI Haven url

update screenshot

replace blurred background hack with new backgroundBlurriness

feat: add USDZ loading, glTF export and USDZ export, FBX material conversion

USDZExporter: fix default plane anchoring orientation and add precision specifiers (mrdoob#25012)

Fixes mrdoob#25011

[XR] Feat: Allow passing GLTFLoader into OculusHandModel/XRHandMeshModel (mrdoob#25013)

* feat: allow passing GLTFLoader into OculusHandModel/XRHandMeshModel

* apply review feedback

USDZExporter: guard against missing image data in textures

USDZLoader: add hierarchy support and fix loading files exported with USDZExporter

GLTFExporter: guard against missing image data in textures

simplify null check

cleanup child name and add example for texture traversal after loading

added file input button, added download button for OBJ
hybridherbst added a commit to needle-tools/three.js that referenced this issue May 23, 2023
… proper disposal, and animation

* added webgl_loader_multiple as example of how to load multiple files one after each other
* added bounds fitting
* added FBX import as second file type example
* added material upgrade of FBX materials to MeshStandardMaterial to receive IBL
* fix minDistance possibly being greater than maxDistance, fix animation loading and playback
* switched to animationLoop

workaround for having a nicely blurred background from the environment

alternative blur approach: use texture mipmaps directly. less pretty

clean up, add link to PR that will introduce background bluriness

fix env bluriness (harder with mipmaps), fix HDRI Haven url

update screenshot

replace blurred background hack with new backgroundBlurriness

feat: add USDZ loading, glTF export and USDZ export, FBX material conversion

USDZExporter: fix default plane anchoring orientation and add precision specifiers (mrdoob#25012)

Fixes mrdoob#25011

[XR] Feat: Allow passing GLTFLoader into OculusHandModel/XRHandMeshModel (mrdoob#25013)

* feat: allow passing GLTFLoader into OculusHandModel/XRHandMeshModel

* apply review feedback

USDZExporter: guard against missing image data in textures

USDZLoader: add hierarchy support and fix loading files exported with USDZExporter

GLTFExporter: guard against missing image data in textures

simplify null check

cleanup child name and add example for texture traversal after loading

added file input button, added download button for OBJ
hybridherbst added a commit to needle-tools/three.js that referenced this issue Jun 10, 2023
… proper disposal, and animation

* added webgl_loader_multiple as example of how to load multiple files one after each other
* added bounds fitting
* added FBX import as second file type example
* added material upgrade of FBX materials to MeshStandardMaterial to receive IBL
* fix minDistance possibly being greater than maxDistance, fix animation loading and playback
* switched to animationLoop

workaround for having a nicely blurred background from the environment

alternative blur approach: use texture mipmaps directly. less pretty

clean up, add link to PR that will introduce background bluriness

fix env bluriness (harder with mipmaps), fix HDRI Haven url

update screenshot

replace blurred background hack with new backgroundBlurriness

feat: add USDZ loading, glTF export and USDZ export, FBX material conversion

USDZExporter: fix default plane anchoring orientation and add precision specifiers (mrdoob#25012)

Fixes mrdoob#25011

[XR] Feat: Allow passing GLTFLoader into OculusHandModel/XRHandMeshModel (mrdoob#25013)

* feat: allow passing GLTFLoader into OculusHandModel/XRHandMeshModel

* apply review feedback

USDZExporter: guard against missing image data in textures

USDZLoader: add hierarchy support and fix loading files exported with USDZExporter

GLTFExporter: guard against missing image data in textures

simplify null check

cleanup child name and add example for texture traversal after loading

added file input button, added download button for OBJ
hybridherbst added a commit to needle-tools/three.js that referenced this issue Jul 6, 2023
… proper disposal, and animation

* added webgl_loader_multiple as example of how to load multiple files one after each other
* added bounds fitting
* added FBX import as second file type example
* added material upgrade of FBX materials to MeshStandardMaterial to receive IBL
* fix minDistance possibly being greater than maxDistance, fix animation loading and playback
* switched to animationLoop

workaround for having a nicely blurred background from the environment

alternative blur approach: use texture mipmaps directly. less pretty

clean up, add link to PR that will introduce background bluriness

fix env bluriness (harder with mipmaps), fix HDRI Haven url

update screenshot

replace blurred background hack with new backgroundBlurriness

feat: add USDZ loading, glTF export and USDZ export, FBX material conversion

USDZExporter: fix default plane anchoring orientation and add precision specifiers (mrdoob#25012)

Fixes mrdoob#25011

[XR] Feat: Allow passing GLTFLoader into OculusHandModel/XRHandMeshModel (mrdoob#25013)

* feat: allow passing GLTFLoader into OculusHandModel/XRHandMeshModel

* apply review feedback

USDZExporter: guard against missing image data in textures

USDZLoader: add hierarchy support and fix loading files exported with USDZExporter

GLTFExporter: guard against missing image data in textures

simplify null check

cleanup child name and add example for texture traversal after loading

added file input button, added download button for OBJ

fix: GLTF and USDZ exporters break with missing images in textures

adjust title and description, convert OBJ mats to MeshStandardMaterial so they use IBL

updated screenshot
hybridherbst added a commit to needle-tools/three.js that referenced this issue Sep 7, 2023
… proper disposal, and animation

* added webgl_loader_multiple as example of how to load multiple files one after each other
* added bounds fitting
* added FBX import as second file type example
* added material upgrade of FBX materials to MeshStandardMaterial to receive IBL
* fix minDistance possibly being greater than maxDistance, fix animation loading and playback
* switched to animationLoop

workaround for having a nicely blurred background from the environment

alternative blur approach: use texture mipmaps directly. less pretty

clean up, add link to PR that will introduce background bluriness

fix env bluriness (harder with mipmaps), fix HDRI Haven url

update screenshot

replace blurred background hack with new backgroundBlurriness

feat: add USDZ loading, glTF export and USDZ export, FBX material conversion

USDZExporter: fix default plane anchoring orientation and add precision specifiers (mrdoob#25012)

Fixes mrdoob#25011

[XR] Feat: Allow passing GLTFLoader into OculusHandModel/XRHandMeshModel (mrdoob#25013)

* feat: allow passing GLTFLoader into OculusHandModel/XRHandMeshModel

* apply review feedback

USDZExporter: guard against missing image data in textures

USDZLoader: add hierarchy support and fix loading files exported with USDZExporter

GLTFExporter: guard against missing image data in textures

simplify null check

cleanup child name and add example for texture traversal after loading

added file input button, added download button for OBJ

fix: GLTF and USDZ exporters break with missing images in textures

adjust title and description, convert OBJ mats to MeshStandardMaterial so they use IBL

updated screenshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants