Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please allow FBXLoader to use every non native texture that ThreeJS can load #28514

Closed
catalin-enache opened this issue May 28, 2024 · 1 comment · Fixed by #28515
Closed

Please allow FBXLoader to use every non native texture that ThreeJS can load #28514

catalin-enache opened this issue May 28, 2024 · 1 comment · Fixed by #28515
Labels
Loaders
Milestone
r166

Comments

@catalin-enache
Copy link
Contributor

catalin-enache commented May 28, 2024 •
edited
Loading

Description

Currently FBXLoader can only use .dds and .tga non native images. However, it could use as well .exr, .tif, .hdr, .ktx2 images.

Note:

  • GLTFLoader already allows that.
  • parseImage(videoNode) does a similar thing (it seems) - asking for specific loaders - but I'm not sure if the same approach should be applied there too. I haven't used video thingies in FBX so far.

Solution

#28515

Alternatives

no need.

Additional context

No response
catalin-enache added a commit to catalin-enache/three.js_fork that referenced this issue May 28, 2024
@catalin-enache
mrdoob#28514 extend FBXLoader textures type
7e6377a
@catalin-enache catalin-enache mentioned this issue May 28, 2024
Merged
@Mugen87 Mugen87 added this to the r165 milestone May 28, 2024
@mrdoob mrdoob modified the milestones: r165, r166 May 31, 2024
Mugen87 added a commit that referenced this issue Jun 1, 2024
@catalin-enache @Mugen87 @mrdoob
FBXLoader: Support more texture formats. (#28515)
6abb47c 
* #28514 extend FBXLoader textures type

* updated tiff image

* Update FBXLoader.js

* Update webgl_loader_fbx.html

* simplified loadTexture logic

* lazy importing loaders

* Revert "lazy importing loaders"

This reverts commit b19dfb8.

* reverted non native textures example

* reverted non native textures example

---------

Co-authored-by: Michael Herzog <michael.herzog@human-interactive.org>
Co-authored-by: mrdoob <info@mrdoob.com>
@catalin-enache
Copy link
Contributor Author

The completed PR (#28515) was accepted and merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Loaders
Projects
None yet
Milestone
r166
Development

Successfully merging a pull request may close this issue.

FBXLoader: Support more texture formats. catalin-enache/three.js_fork
3 participants
@mrdoob @catalin-enache @Mugen87