Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

USDZLoader: loading a binary file does not throw error #28684

Closed
zaesur opened this issue Jun 17, 2024 · 0 comments · Fixed by #28685
Closed

USDZLoader: loading a binary file does not throw error #28684

zaesur opened this issue Jun 17, 2024 · 0 comments · Fixed by #28685
Labels
Loaders
Milestone
r166

Comments

@zaesur
Copy link
Contributor

zaesur commented Jun 17, 2024

Description

While other loaders throw errors upon encountering a non-recoverable issue, the USDZ loader merely logs a warning and returns an empty group.

USDZLoader should throw an error such that developers may handle it accordingly, instead of receiving a nullish value (empty group).

I've used the following asset for testing: https://developer.apple.com/augmented-reality/quick-look/models/cupandsaucer/cup_saucer_set.usdz

Reproduction steps

  1. Load USDZ file containing one or more 'crate' files using USDZLoader
  2. Empty scene is loaded, only warnings in console.

Code

USDZLoader.load("cup_saucer_set.usdz")

Live example

N/A

Screenshots

No response

Version

r165

Device

Desktop

Browser

Firefox

OS

Linux
zaesur added a commit to zaesur/three.js that referenced this issue Jun 17, 2024
@zaesur
USDZLoader: throw error instead of warning (mrdoob#28684)
92943a3 
USDZLoader should throw an error instead of the warning, to allow the
consumer to act upon the error.
zaesur added a commit to zaesur/three.js that referenced this issue Jun 17, 2024
@zaesur
USDZLoader: throw error instead of warning (mrdoob#28684)
ffa42cc 
USDZLoader should throw an error instead of the warning, to allow the
consumer to act upon the error.
@zaesur zaesur mentioned this issue Jun 17, 2024
Merged
mrdoob pushed a commit that referenced this issue Jun 18, 2024
@zaesur
USDZLoader: throw error instead of warning (#28684) (#28685)
ce72acd 
USDZLoader should throw an error instead of the warning, to allow the
consumer to act upon the error.
@Mugen87 Mugen87 added this to the r166 milestone Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Loaders
Projects
None yet
Milestone
r166
Development

Successfully merging a pull request may close this issue.

USDZLoader: throw error instead of warning zaesur/three.js
2 participants
@Mugen87 @zaesur