-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getShadowMask equivalent in TSL #30220
Comments
@Mugen87 I think these examples like |
That sounds good to me. Using |
About general customisation of materials, Is there a way to get access an equivalent of getShadowMask ? |
The same hack is required by I am inclined to think that a better approach would be to improve the water shader -- and, perhaps, deprecate both |
In the meanwhile, I also think that just having Phong shading in materials is more beneficial than the small performance benefit of Gouraud shading. We end up with more consistent materials and less edge cases. Hence, I support the suggested deprecation. |
Since shadow is the absence of light, in this case when we update Water to a material that is compatible with lighting, you can use |
Description
Hey there !
Ocean Water from legacy to TSL,
The Ocean TSL examples does not support shadow-mapping as in the legacy one :
https://github.com/mrdoob/three.js/blob/master/examples/jsm/objects/Water.js#L181C71-L181C84
I was looking for an equivalent of getShadowMask, to be used inside a fragmentNode, checked on the examples and the wiki but had no chance :
float shadowMask = getShadowMask();
The text was updated successfully, but these errors were encountered: