NodeMaterial: Added .castShadowNode
and .receivedShadowNode
#29840
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #29838 (comment)
Description
Renaming
.shadowNode
to.castShadowNode
seems like a better name and more in line with the Three.js API regarding shadow casting..receivedShadowNode
is the new input, and should use TSLFn
as input, where the manipulation of the received shadow can be performed. UsingFn
we can also create theshadows
mask manually, so I removed the nodeshadows
to avoid redundancy.material.castShadowNode
andmaterial.receivedShadowNode
shadows
Manual way to add
shadows