Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MeshBasicMaterial documentation innacuracy, suggestion #4265

Closed
ijx33 opened this issue Jan 5, 2014 · 3 comments
Closed

MeshBasicMaterial documentation innacuracy, suggestion #4265

ijx33 opened this issue Jan 5, 2014 · 3 comments
Labels
Bug

Comments

@ijx33
Copy link

ijx33 commented Jan 5, 2014

In https://github.com/mrdoob/three.js/blob/dev/docs/api/materials/MeshBasicMaterial.html

"vertexColors" is confusingly (?me) marked as "boolean", but takes integer values.

Suggest adding

"Set to THREE.VertexColors to use vertex colors, and to THREE.FaceColors to use face colors"

I couldn't find this anywhere else in the docs.
@mrdoob
Copy link
Owner

mrdoob commented Jan 7, 2014

Ah, yes. It's definitely not a Boolean.
Do you think you could create a PR with this change?

@mrdoob
Copy link
Owner

mrdoob commented Jan 7, 2014

Actually. I'll fix it directly :)

mrdoob added a commit that referenced this issue Jan 7, 2014
@mrdoob
Docs: Fixed vertexColors description. Fixes #4265.
d0c0d25
@mrdoob
Copy link
Owner

mrdoob commented Jan 7, 2014

Fixed. Thanks! :)

@mrdoob mrdoob closed this as completed Jan 7, 2014
@snyk-bot snyk-bot mentioned this issue Dec 13, 2021
Open
@snyk-bot snyk-bot mentioned this issue Dec 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mrdoob @ijx33