Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compressed textures (Eg DDS/crunch) not supported by ObjectLoader #7452

Closed
erno opened this issue Oct 26, 2015 · 3 comments
Closed

Compressed textures (Eg DDS/crunch) not supported by ObjectLoader #7452

erno opened this issue Oct 26, 2015 · 3 comments

Comments

@erno
Copy link

erno commented Oct 26, 2015

There is also no obvious place make this happen in your own code, short of
modifying ObjectLoader.

Currently the code uses ImageLoader which doesn't handle compressed textures.
A possible approach could be a new autodetecting image loader that could use
ImageLoader or DDSLoader (or PVR or ...) depending on type of image data encountered,
and a corresponding change in parseTextures
where it calls into the new loader for the Texture or CompressedTexture instance.

antont added a commit to playsign/OuluThreeJS that referenced this issue Mar 3, 2016
@antont
Copy link
Contributor

antont commented Mar 3, 2016

any ideas here? am reading ObjectLoader and its use of ImageLoader to see how it goes now and perhaps find some way to add support for compressed ones

@antont
Copy link
Contributor

antont commented Mar 14, 2016

tested by hacking ObjectLoader in a separate test copy ('ObjectLoaderDDS') back then.

happened to see this niceness in obj & mtl loading example now:

THREE.Loader.Handlers.add( /\.dds$/i, new THREE.DDSLoader() );

https://github.com/mrdoob/three.js/blob/dev/examples/webgl_loader_obj_mtl.html#L88

@Mugen87
Copy link
Collaborator

Mugen87 commented Mar 3, 2021

Merged into #17974.

@Mugen87 Mugen87 closed this as completed Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants