Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AnimationClip nodeName #9669

Closed
milewski opened this issue Sep 12, 2016 · 3 comments · Fixed by #19232
Closed

AnimationClip nodeName #9669

milewski opened this issue Sep 12, 2016 · 3 comments · Fixed by #19232

Comments

@milewski
Copy link

milewski commented Sep 12, 2016 •
edited
Loading

why do i need to set a nodeName? if the same doesn't seen to be used anywhere?... it just keeps making my ide complaining i am missing arguments...

three.js/src/animation/AnimationClip.js

Line 238 in 7714fe8

parseAnimation: function( animation, bones, nodeName ) {

@mrdoob
Copy link
Owner

mrdoob commented Sep 13, 2016

/ping @tschw

@tschw
Copy link
Contributor

tschw commented Sep 14, 2016

I don't think I have added it, so I really have no clue what it used to be for. Since it's not referenced anywhere, I guess it'd be best to just remove it.

@mrdoob mrdoob closed this as completed in 4baf3e5 Sep 14, 2016
@mrdoob
Copy link
Owner

mrdoob commented Sep 14, 2016

Fixed. Thanks!

aardgoose pushed a commit to aardgoose/three.js that referenced this issue Oct 7, 2016
@mrdoob @aardgoose
AnimationClip: Removed unused nodeName. Fixes mrdoob#9669.
6a062aa
@Kurogoma4D Kurogoma4D mentioned this issue Apr 26, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TS: Update AnimationClip Kurogoma4D/three.js
3 participants
@mrdoob @milewski @tschw