Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CRLF issues with global find and dos2unix #13262

Closed
wants to merge 1 commit into from

Conversation

kaisalmen
Copy link
Contributor

This resolves #13224

@kaisalmen
Copy link
Contributor Author

Why do the checks always fail on me, la la lalala 😉 any idea?

@mrdoob
Copy link
Owner

mrdoob commented Feb 7, 2018

Do you mind doing it again? Seems like a PR I just merged it's already conflicting 😇

find . -not \( -path "./.git/*" -o -path "./node_modules/*" \) -type f -exec dos2unix {} \;
@kaisalmen
Copy link
Contributor Author

Try again... 👍

@mrdoob mrdoob added this to the r90 milestone Feb 8, 2018
mrdoob added a commit that referenced this pull request Feb 8, 2018
@mrdoob
Copy link
Owner

mrdoob commented Feb 8, 2018

Applied the global dox2unix locally. 3bcb9c2

@mrdoob mrdoob closed this Feb 8, 2018
@mrdoob
Copy link
Owner

mrdoob commented Feb 8, 2018

Thanks!

@kaisalmen kaisalmen deleted the dos2unix branch February 9, 2018 16:56
Repository owner deleted a comment from shi-yan Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we fix all CRLF issues?
2 participants