Examples: Add demo for indexed BufferGeometry #13266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WestLangley
reviewed
Feb 7, 2018
|
|
||
| // | ||
|
|
||
| var ambientLight = new THREE.AmbientLight( 0xcccccc ); |
There was a problem hiding this comment.
Ambient light should never be that high. Try 0x222222.
WestLangley
reviewed
Feb 7, 2018
| light1.position.set( 1, 1, 1 ); | ||
| scene.add( light1 ); | ||
|
|
||
| var light2 = new THREE.DirectionalLight( 0xffffff, 1.5 ); |
There was a problem hiding this comment.
Try not not over-brighten you scene.
WestLangley
reviewed
Feb 7, 2018
| geometry.addAttribute( 'color', new THREE.Float32BufferAttribute( colors, 3 ) ); | ||
|
|
||
| var material = new THREE.MeshPhongMaterial( { | ||
| specular: 0xffffff, shininess: 250, |
There was a problem hiding this comment.
If the specular reflectance of the material is 0xffffff, and the diffuse reflectance is greater than zero, then more than 100% of the light is being reflected. Set specular to 0x111111. Study the hot-spot before and after.
There was a problem hiding this comment.
BTW: I've just copied the material/lights from an other example. We might want to review the lightings in the examples at some point...
There was a problem hiding this comment.
Right. Check the outline pass demo. :/
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #13259
Also correct the docs.