Added #include_once shader directive and circular inclusion detection #13282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've spent the last day or so trying to figure out how to create my own shader by reusing as much as possible from three.js's included ShaderChunk library. What I found particularly annoying about it, was figuring out how these chunks depend on each other, since they never include their own dependencies, like the common chunk.
With these changes, each chunk should be able to declare
#include_once <...>
to declare their dependencies without having to worry about including chunks more than once. And while I was at it I also added circular inclusion detection for regular includes.I didn't know how to write unit tests for
parseIncludes()
without exporting it or writing actual shaders that do compile. Examples seem to still work as expected.I didn't actually rewrite glsl files for now, but I hope this can be used to write more comprehensive shader libraries in the future.