Added LightProbe class #16191
Merged
Added LightProbe class #16191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WIP. Sphere illuminated by LightProbe only. Probe SH coefficients computed from environment map. |
|
This looks awesome!
I've been working on a GPU based version here #16152 which I think I can make a bit more mathematically correct referencing this CPU implementation! |
WestLangley
force-pushed
the
dev-light_probe
branch
from
e6c52aa to
dd526f1
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will have to continue to discuss this, and what it represents. To me, it models indirect, ambient light, and in that sense, is a generalization of
AmbientLightorHemisphereLight.I've included a method
LightProbe.setFromCubeTexture()that computes the SH coefficients. From testing, it works as one would expect. The method can be replaced with a faster GPU-based one later.This PR relies on #16187.