WebGLTextures: Used sized internal format for depth stencil #16769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Before merging this we might want to wait for some feedback here: #16756 (comment) |
|
Ok, from reading the spec Chrome is compliant, Firefox has just extended the laxity of WebGL1 to WebGL2 functions (internally to FF both renderbufferStorage variants take exactly the same path where the translation of DEPTH_STENCIL to DEPTH24_STENCIL8 takes place, before hitting ANGLE etc ). |
Mugen87
approved these changes
Jun 14, 2019
Mugen87
changed the title
|
Thanks! |
|
@aardgoose Since you introduced a new constant, it's necessary to add it right here: https://github.com/mrdoob/three.js/blob/dev/rollup.config.js#L3 Otherwise you can a warning when performing the build:
|
|
Fixed ab13080 |
|
@Mugen87 |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #16756
gl.renderbufferStorageMultisample() requires a sized internal format specifier. Chrome enforces this, firefox extends the behaviour of renderbufferStorage():
To be backward compatible with WebGL 1, also accepts internal format DEPTH_STENCIL, which should be mapped to DEPTH24_STENCIL8 by implementations.to renderbufferStorageMultisample() which is not required by the spec.