Skip to content

DragControls: Remove deprecated API and checks. #17416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mrdoob merged 1 commit into from
Sep 3, 2019
Merged

DragControls: Remove deprecated API and checks. #17416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 0 additions & 36 deletions examples/js/controls/DragControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,6 @@

THREE.DragControls = function ( _objects, _camera, _domElement ) {

if ( _objects instanceof THREE.Camera ) {

console.warn( 'THREE.DragControls: Constructor now expects ( objects, camera, domElement )' );
var temp = _objects; _objects = _camera; _camera = temp;

}

var _plane = new THREE.Plane();
var _raycaster = new THREE.Raycaster();

Expand Down Expand Up @@ -251,35 +244,6 @@ THREE.DragControls = function ( _objects, _camera, _domElement ) {
this.deactivate = deactivate;
this.dispose = dispose;

// Backward compatibility

this.setObjects = function () {

console.error( 'THREE.DragControls: setObjects() has been removed.' );

};

this.on = function ( type, listener ) {

console.warn( 'THREE.DragControls: on() has been deprecated. Use addEventListener() instead.' );
scope.addEventListener( type, listener );

};

this.off = function ( type, listener ) {

console.warn( 'THREE.DragControls: off() has been deprecated. Use removeEventListener() instead.' );
scope.removeEventListener( type, listener );

};

this.notify = function ( type ) {

console.error( 'THREE.DragControls: notify() has been deprecated. Use dispatchEvent() instead.' );
scope.dispatchEvent( { type: type } );

};

};

THREE.DragControls.prototype = Object.create( THREE.EventDispatcher.prototype );
Expand Down
37 changes: 0 additions & 37 deletions examples/jsm/controls/DragControls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@
*/

import {
Camera,
EventDispatcher,
Matrix4,
Plane,
Expand All @@ -16,13 +15,6 @@ import {

var DragControls = function ( _objects, _camera, _domElement ) {

if ( _objects instanceof Camera ) {

console.warn( 'THREE.DragControls: Constructor now expects ( objects, camera, domElement )' );
var temp = _objects; _objects = _camera; _camera = temp;

}

var _plane = new Plane();
var _raycaster = new Raycaster();

Expand Down Expand Up @@ -261,35 +253,6 @@ var DragControls = function ( _objects, _camera, _domElement ) {
this.deactivate = deactivate;
this.dispose = dispose;

// Backward compatibility

this.setObjects = function () {

console.error( 'THREE.DragControls: setObjects() has been removed.' );

};

this.on = function ( type, listener ) {

console.warn( 'THREE.DragControls: on() has been deprecated. Use addEventListener() instead.' );
scope.addEventListener( type, listener );

};

this.off = function ( type, listener ) {

console.warn( 'THREE.DragControls: off() has been deprecated. Use removeEventListener() instead.' );
scope.removeEventListener( type, listener );

};

this.notify = function ( type ) {

console.error( 'THREE.DragControls: notify() has been deprecated. Use dispatchEvent() instead.' );
scope.dispatchEvent( { type: type } );

};

};

DragControls.prototype = Object.create( EventDispatcher.prototype );
Expand Down