-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GLTFExporter: Fixed alphaMode handling #17433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, this change is more intuitive and supports cases where material.transparent = true
but material.opacity = 1.0
(e.g. the transparency is in .map
instead).
Aside, I do like the idea of having an |
Yeah, I was re-exporting the Flight Helmet and it was setting
Hmm, yeah. We may have to refactor a few things. |
glTF doesn't specify, although it probably should. In the meantime I have no objection to changing it. 😇 |
Seems better though. |
I'll continue testing. Merging this for now. |
I think the current logic is broken.
@fernandojsg @donmccurdy let me know if this looks good to you.