Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Removed outdated information #17580

Merged
merged 1 commit into from
Sep 27, 2019
Merged

Docs: Removed outdated information #17580

merged 1 commit into from
Sep 27, 2019

Conversation

atul-mourya
Copy link
Contributor

@atul-mourya atul-mourya commented Sep 26, 2019

Dynamic addition of light in run-time does seems to be possible in three.js

Dynamic addition of light in run-time does seems to be possible
@looeee
Copy link
Collaborator

looeee commented Sep 26, 2019

You can certainly add/change lights at run time. Please use the forum if you need help with this.

@looeee looeee closed this Sep 26, 2019
@atul-mourya atul-mourya deleted the patch-6 branch September 26, 2019 08:42
@WestLangley
Copy link
Collaborator

@looeee Why did you label this a help request and close it?

This PR appears to me to be a proposed update to an outdated document.

@atul-mourya atul-mourya restored the patch-6 branch September 26, 2019 17:02
@atul-mourya
Copy link
Contributor Author

atul-mourya commented Sep 26, 2019

@WestLangley Yes, that was my intent. Was looking to update which seems to me outdated.
Correct me if I'm wrong with the proposed content.

@WestLangley
Copy link
Collaborator

@atul-mourya The document is old and needs to be updated with more precise language. There is nothing wrong with what you intended to do.

@mrdoob
Copy link
Owner

mrdoob commented Sep 27, 2019

What @WestLangley said.

@mrdoob mrdoob reopened this Sep 27, 2019
@mrdoob mrdoob added this to the r109 milestone Sep 27, 2019
@mrdoob mrdoob changed the title Removed confusing part Docs: Removed outdated information Sep 27, 2019
@mrdoob mrdoob merged commit ab18028 into mrdoob:dev Sep 27, 2019
@mrdoob
Copy link
Owner

mrdoob commented Sep 27, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants