RangeFog and DensityFog #17592

EliasHasle · 2019-09-27T15:38:58Z

Replaces #17355.

RangeFog(color, near, far) and DensityFog(color, density, squared), as requested in #17420 (comment)

Includes the change to distance-based depth, as well as corrections to better support mediump and lowp. Makes #17316 and #17324 obsolete.

DensityFog: To make sure a change to squared causes the necessary material update, a needsUpdate is used internally and handled by the renderer. (Does needsUpdate also have to be declared in DensityFog.d.ts?)

The fog types example is live on my website.
Test of legacy signatures
Test of mediump
Test of lowp
It looks suspiciously good with mediump and lowp on my desktop, probably because the precision specifiers are minimal requirements. These ones must be tested on actual mediump/lowp devices.

The editor works too. It is not perfectly user-friendly to only have an unlabeled checkbox to represent squared, though. (Unlabeled controls seems to be a global problem in the editor).

Mugen87 · 2019-09-27T15:57:08Z

But I think it will be ready for r109 after all.

No rush. I don't think merging this in that short amount if time is good. Better to target a later release. There are some other things that need to be fixed and tested for R109 already.

Mugen87 · 2019-09-27T16:09:36Z

I think it's better to stick to the old style for now. I'm not sure how fast we move on with this topic.

src/renderers/WebGLRenderer.d.ts

Mugen87 · 2019-10-30T14:25:48Z

I normally don't do that if files in the core change. In this case, it's best to download your branch and test locally.

Mugen87 · 2020-01-03T13:35:59Z

Read the tooltip 😊

Feirell · 2021-03-03T10:48:32Z

Well this could fix things for me, I really hope this gets some traction again and not vanish in the deep dark.

LeviPesin · 2022-03-29T05:28:41Z

@EliasHasle Can you please update this PR?

EliasHasle · 2023-03-24T09:29:16Z

@EliasHasle Can you please update this PR?

Done! I used a reset and a Yoda move (force push). The docs are not updated yet, though.

…5498) * Nodes: Rework ShaderNodeElements and make some other refactorings * Fixes * fix add assign * Fix circular dependency and clean up * Rename addNode -> addNodeElement and LightsNode.setReference -> addLightNode, add addNodeClass and addNodeMaterial --------- Co-authored-by: sunag <sunagbrasil@gmail.com>

github-actions · 2023-03-27T13:42:46Z

📦 Bundle size

Full ESM build, minified and gzipped.

Filesize	Gzipped	Diff from `dev`
634.8 kB	157.4 kB	+1.13 kB

🌳 Bundle size after tree-shaking

Minimal build including a renderer, camera, empty scene, and dependencies.

Filesize	Gzipped	Diff from `dev`
425.6 kB	103.2 kB	+645 B

test/unit/src/scenes/DensityFog.tests.js

examples/webgl_geometry_terrain_fog_types.html

test/unit/src/scenes/DensityFog.tests.js

src/renderers/WebGLRenderer.js

examples/screenshots/webgl_geometry_terrain_fog_types.jpg

src/loaders/ObjectLoader.js

src/Three.Legacy.js

EliasHasle · 2023-03-31T05:09:29Z

The rationale for using only depth rather than Euclidean distance from a single point for fog with orthographic projection is that every pixel on the screen represents a parallel "eye beam", whereas with perspective projection, the camera position represents the focal point, ideally located at the position of the observer in front of the screen, where the screen is the projection plane (or "window" to the virtual world). (Nevermind that most demos and games inflate the FOV way beyond the typical eye-screen angle, for practical gameplay/immersion purposes.)

Neither builds, docs, manual nor the FogExp2Node are updated in this commit. Work in progress. I think one should consider making `vViewPosition` a dependency for all shaders that use fog, instead of adding the new `vFogPosition`. Fixed dirtiness logic in WebGLRenderer and the automatically detected errors Also improved the example and added a thumbnail for it. Update src/Three.Legacy.js Shorter deprecation warning for `FogExp2`. Co-authored-by: Levi Pesin <35454228+LeviPesin@users.noreply.github.com> Fix JSON logic

…rojection

None of the `exp`s can return >1 or <0 given the new, necessarily non-positive, arguments.

EliasHasle · 2023-04-12T11:39:13Z

Well this could fix things for me, I really hope this gets some traction again and not vanish in the deep dark.

@Feirell Do you mind testing the newest version?

This PR should be ready for review now. @mrdoob @Mugen87 @LeviPesin

Given the parameterisation with an optional squared, I would prefer to have it false by default, because FOG_EXP retains at least a rudimentary physical realism that FOG_EXP2 sacrifices. (It could also simplify some logic for JSON etc.) But for now, I have left it true by default, as requested.

Feirell · 2023-04-20T11:22:46Z

@EliasHasle sorry to disappoint but the usecase I had has long moved on. I switched to a different approach entirely. Depending on if you believe that another tester is useful, I could cobble together a quick scene and test if it works as I would expect it to.

Non the less, thank you for your work and effort!

EliasHasle mentioned this pull request Sep 27, 2019

Broken PR: RangeFog and DensityFog #17355

Closed

EliasHasle force-pushed the FogExp_and_safe_distance_fog branch from 8b90e58 to 2f3b28f Compare September 27, 2019 15:49

EliasHasle force-pushed the FogExp_and_safe_distance_fog branch from 2f3b28f to 1bd6e9d Compare September 27, 2019 16:04

This comment was marked as resolved.

Sign in to view

EliasHasle force-pushed the FogExp_and_safe_distance_fog branch from 1bd6e9d to 39030ff Compare September 27, 2019 16:09

EliasHasle force-pushed the FogExp_and_safe_distance_fog branch 2 times, most recently from 82dd31e to 5eddba2 Compare September 27, 2019 16:31

EliasHasle marked this pull request as ready for review September 27, 2019 17:01

EliasHasle mentioned this pull request Sep 27, 2019

Scene: background, fog and shadow. #17420

Open

EliasHasle force-pushed the FogExp_and_safe_distance_fog branch 2 times, most recently from 42e49f4 to 0dbf102 Compare September 27, 2019 22:48

EliasHasle commented Sep 27, 2019

View reviewed changes

src/renderers/WebGLRenderer.d.ts Outdated Show resolved Hide resolved

EliasHasle force-pushed the FogExp_and_safe_distance_fog branch from 0dbf102 to d6daef1 Compare September 27, 2019 23:06

EliasHasle mentioned this pull request Oct 12, 2019

Shading models using incorrect view direction for orthographic projections. #17662

Closed

This comment was marked as outdated.

Sign in to view

EliasHasle mentioned this pull request Oct 27, 2019

ShaderChunks: Fix orthographic view direction #17767

Merged

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

EliasHasle force-pushed the FogExp_and_safe_distance_fog branch from 9c002ac to 2a938de Compare January 3, 2020 15:12

This was referenced Dec 6, 2020

Fix fog to use view distance #17316

Closed

MeshDepthMaterial: Compute depth manually rather than using gl_FragCoord.z #18696

Merged

This comment was marked as outdated.

Sign in to view

Mugen87 mentioned this pull request Mar 15, 2021

Distance based fog? #14601

Closed

2 tasks

EliasHasle mentioned this pull request Mar 24, 2023

FOG_EXP2: Avoid possible over-/underflow when squaring on mediump #17324

Draft

EliasHasle force-pushed the FogExp_and_safe_distance_fog branch from 2a938de to 36bcc71 Compare March 27, 2023 13:39

github-advanced-security bot found potential problems Mar 27, 2023

View reviewed changes

EliasHasle marked this pull request as draft March 27, 2023 14:19

EliasHasle force-pushed the FogExp_and_safe_distance_fog branch from 18e57d1 to 1dd9f2a Compare March 28, 2023 12:48

EliasHasle commented Mar 29, 2023

View reviewed changes

src/renderers/WebGLRenderer.js Show resolved Hide resolved

EliasHasle commented Mar 29, 2023

View reviewed changes

examples/screenshots/webgl_geometry_terrain_fog_types.jpg Outdated Show resolved Hide resolved

LeviPesin reviewed Mar 29, 2023

View reviewed changes

src/loaders/ObjectLoader.js Outdated Show resolved Hide resolved

LeviPesin reviewed Mar 29, 2023

View reviewed changes

src/Three.Legacy.js Outdated Show resolved Hide resolved

EliasHasle marked this pull request as ready for review March 31, 2023 08:44

EliasHasle force-pushed the FogExp_and_safe_distance_fog branch from 8eb6655 to 042568b Compare March 31, 2023 08:45

EliasHasle added 5 commits April 12, 2023 11:38

Restrict fog depth to projection-parallel distance for Orthographic p…

651512a

…rojection

Simplify fog_vertex

7dd497b

Fixed fog support in editor

a26d952

Correct docs

184e987

EliasHasle force-pushed the FogExp_and_safe_distance_fog branch from 042568b to 57eeb7f Compare April 12, 2023 09:52

EliasHasle added 2 commits April 12, 2023 13:25

fog_fragment: Simplify away whiteComplement

8f6bf87

None of the `exp`s can return >1 or <0 given the new, necessarily non-positive, arguments.

New screenshots for some examples (especially those that have fog)

4bea924

EliasHasle force-pushed the FogExp_and_safe_distance_fog branch from 57eeb7f to 4bea924 Compare April 12, 2023 11:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

RangeFog and DensityFog #17592

RangeFog and DensityFog #17592

EliasHasle commented Sep 27, 2019 •

edited

Loading

Mugen87 commented Sep 27, 2019 •

edited

Loading

This comment was marked as resolved.

Mugen87 commented Sep 27, 2019

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Mugen87 commented Oct 30, 2019

This comment was marked as resolved.

Mugen87 commented Jan 3, 2020

This comment was marked as outdated.

This comment was marked as outdated.

Feirell commented Mar 3, 2021

LeviPesin commented Mar 29, 2022

EliasHasle commented Mar 24, 2023 •

edited

Loading

github-actions bot commented Mar 27, 2023 •

edited

Loading

EliasHasle commented Mar 31, 2023 •

edited

Loading

EliasHasle commented Apr 12, 2023

Feirell commented Apr 20, 2023

RangeFog and DensityFog #17592

Are you sure you want to change the base?

RangeFog and DensityFog #17592

Conversation

EliasHasle commented Sep 27, 2019 • edited Loading

Mugen87 commented Sep 27, 2019 • edited Loading

This comment was marked as resolved.

Mugen87 commented Sep 27, 2019

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

Mugen87 commented Oct 30, 2019

This comment was marked as resolved.

Mugen87 commented Jan 3, 2020

This comment was marked as outdated.

This comment was marked as outdated.

Feirell commented Mar 3, 2021

LeviPesin commented Mar 29, 2022

EliasHasle commented Mar 24, 2023 • edited Loading

github-actions bot commented Mar 27, 2023 • edited Loading

📦 Bundle size

🌳 Bundle size after tree-shaking

EliasHasle commented Mar 31, 2023 • edited Loading

EliasHasle commented Apr 12, 2023

Feirell commented Apr 20, 2023

EliasHasle commented Sep 27, 2019 •

edited

Loading

Mugen87 commented Sep 27, 2019 •

edited

Loading

EliasHasle commented Mar 24, 2023 •

edited

Loading

github-actions bot commented Mar 27, 2023 •

edited

Loading

EliasHasle commented Mar 31, 2023 •

edited

Loading