Several PMREMGenerator fixes #18045
Several PMREMGenerator fixes #18045
Conversation
|
Thanks! |
| envScene.add(mainLight); | ||
|
|
||
| var lightMaterial = new THREE.MeshBasicMaterial(); | ||
| lightMaterial.color.setScalar(20); |
There was a problem hiding this comment.
We don't set colors to [ 20, 20, 20 ]. Color is the diffuse reflectance of the material, it is unit-less, and takes values in [ 0, 1 ].
There was a problem hiding this comment.
As far as I understand this is emulating a very bright light.
So there is no other way to do this than by going over 1?
There was a problem hiding this comment.
Setting the diffuse reflectance to a value greater than 1 means that more light is reflected than is incident. We should not be doing that.
You can add a light to the scene and increase the light's intensity.
You can also set material.emissive ( in [0, 1] ) and material.emissiveIntensity, which is unbounded.
There was a problem hiding this comment.
Hmm, MeshBasicMaterial doesn't have emissive...
So in order to create "RectAreaLights" when generating envMaps you recomend doing this:
new THREE.MeshStandardMaterial( { emissive: 0xffffff, emissiveIntensity: 20 } );Instead of this:
new THREE.MeshBasicMaterial( { color: new THREE.Color().setScalar( 20 ) } );Right?
There was a problem hiding this comment.
Actually, I wrote a RectAreaLightHelper, but I specifically set the rectangle color so it wouldn't over-bright or hue shift as the light intensity increases. I think you will have to experiment with it so you will understand what I am referring to. :-)
Tip: RectAreaLightHelper must be added as a child of the light.
There was a problem hiding this comment.
You'll need tone-mapping and exposure control.
There was a problem hiding this comment.
Hmm... Even when tone-mapped, it is hue-shifting to white unless the exposure is very low... Bummer.
Well, that is a separate issue...
There was a problem hiding this comment.
Thanks for the discussion; should I change this to MeshLambertMaterial then?
There was a problem hiding this comment.
Or RectAreaLightHelper?
There was a problem hiding this comment.
Using MeshLambertMaterial sounds good to me.
Fixes #18029
I found a better way to fix the above issue was correctly using the scissor test, thus preserving any desired clearing behavior. In addition I found several uses of the cube shader I had forgotten to update, so this fixes several examples that were broken by my last change.
I also added a
Generatedoption to the webgl_materials_envmaps_hdr example to serve as an example for using PMREMGenerator.fromScene() and to act as a test for the issue that was fixed here.