WebGLRenderer: Fixed shader compile error. #18299
Merged
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of this fix: google/model-viewer#920
It was causing the PMREM shaders to fail compilation on an Alcatel A502DL, which I was able to repro on three's gltf loader example. Oddly, it does not fail the MeshStandardMaterial compilation, even though it uses the same shader fragment, so this is a pretty strange driver bug. It doesn't even give an error or line number when the compilation fails, which made finding this fix a bit tricky. Thanks to @cdata for his help hunting it down line by line when he was the only one with a repro device.