Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebGLRenderer: Fixed shader compile error. #18299

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Conversation

elalish
Copy link
Contributor

@elalish elalish commented Jan 3, 2020

This is a port of this fix: google/model-viewer#920
It was causing the PMREM shaders to fail compilation on an Alcatel A502DL, which I was able to repro on three's gltf loader example. Oddly, it does not fail the MeshStandardMaterial compilation, even though it uses the same shader fragment, so this is a pretty strange driver bug. It doesn't even give an error or line number when the compilation fails, which made finding this fix a bit tricky. Thanks to @cdata for his help hunting it down line by line when he was the only one with a repro device.

@mrdoob mrdoob added this to the r113 milestone Jan 3, 2020
@mrdoob mrdoob merged commit 07f4f5d into mrdoob:dev Jan 3, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jan 3, 2020

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Jan 3, 2020

FYI @kenrussell

@Mugen87 Mugen87 changed the title fixed compile error WebGLRenderer: Fixed shader compile error. Jan 3, 2020
@kenrussell
Copy link

Interesting - would this be reproducible with a small shader snippet using the framework from the WebGL conformance tests here:
https://github.com/KhronosGroup/WebGL/tree/master/sdk/tests/conformance/glsl/bugs

Or does this need more of the shader in order to reproduce?

If you can boil this down to a small failing shader, please file an issue on that repository and/or put up a pull request adding a test covering this bug. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants