-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGLCubeRenderTarget: simplify constructor signature #18300
Conversation
I'm unsure about |
Done!
A cube has 6 identically-sized 2D faces. I am not aware of a WebGL 2.0 use case that is different. |
Maybe it's more safe to keep the signature as it is since it's more flexibel. How knows which use cases come up in the future.... |
This is not about use cases. There are no other use cases allowed. If you pass in a |
Um, is this also true for |
It is true everywhere: A cube has 6 square sides. We should not have had both width and height parameters in the first place. |
@mrdoob I honored your requested change. |
Thanks! |
Since
width
andheight
must be the same, this PR simplifies the constructor signature:is now