New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Examples: Avoid creating instances of LightShadow. #18309

Merged

mrdoob merged 1 commit into mrdoob:dev from Mugen87:dev29

Jan 5, 2020

+11 −17

Collaborator

Mugen87 commented Jan 5, 2020

The example code should not recommend to overwrite light.shadow.

Besides, using a directional light in webgl_shading_physical seems more appropriate.


          Examples: Avoid creating instances of LightShadow.

cecc159

mrdoob added this to the r113 milestone

mrdoob merged commit fa90a9d into mrdoob:dev

Owner

mrdoob commented Jan 5, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet