Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't double-invert view matrix in WebXRManager #18345

Merged
merged 1 commit into from
Jan 9, 2020
Merged

Don't double-invert view matrix in WebXRManager #18345

merged 1 commit into from
Jan 9, 2020

Conversation

willcassella
Copy link

@willcassella willcassella commented Jan 8, 2020 •
edited
Loading

Doing this every frame isn't good for performance, and it's not necessary

@mrdoob mrdoob added this to the r113 milestone Jan 9, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jan 9, 2020

Good catch!

@mrdoob mrdoob merged commit 2930462 into mrdoob:dev Jan 9, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jan 9, 2020

Thanks!

@willcassella willcassella deleted the double-inversion branch January 9, 2020 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r113
Development

Successfully merging this pull request may close these issues.
2 participants
@willcassella @mrdoob