Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera: update matrixWorldInverse in updateWorldMatrix() method #18351

Merged
merged 1 commit into from
Jan 10, 2020

Conversation

DavidPeicho
Copy link
Contributor

For people not using matrixAutoUpdate, and using updateWorldMatrix(), it's possible to end up in a case where the camera matrixWorldInverse is actually out-of-date.

This PR makes the Camera class override the updateWorldMatrix().

@Mugen87 Mugen87 added this to the r113 milestone Jan 9, 2020
@Mugen87 Mugen87 merged commit 998a21e into mrdoob:dev Jan 10, 2020
@DavidPeicho DavidPeicho deleted the fix/camera-matrixworldinv branch January 10, 2020 10:39
@mrdoob
Copy link
Owner

mrdoob commented Jan 10, 2020

Thanks!

@riebling
Copy link

riebling commented Feb 4, 2020

I hope this has nothing to do with (we're still trying to track down what causes!) a predicament where Firefox-webxr on an iOS device, using A-Frame in AR mode, on top of three.js reports it's camera world coordinates all backwards: move the device down, Y increases. Move it to the left, X increases. Move it away from you, Z increases. All the 'inverse' of what we expect :) Probably just a coincidence. Carry on, & thanks for the good work

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 4, 2020

WebXRManager does not use Camera.updateWorldMatrix() so it seems what you report is unrelated to this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants