WebGLAttributes: Reduce heap allocations when using WebGL2 and partial buffer updates. #18418
+15
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mugen87
approved these changes
Jan 19, 2020
Mugen87
changed the title
Usnul
approved these changes
Jan 20, 2020
|
Updated builds 4939ed5. |
|
Thanks! |
|
FYI ce45cc3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the need to create new TypedArray objects when using attribute.updateRange by using the bufferSubData() WebGL2 API which removes the need for TypedArray.subarray().
See #18387 for diagnosis and details.
Tested and reduces GC frequency