Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeMaterial: fixes #18439

Merged
merged 3 commits into from
Jan 21, 2020
Merged

NodeMaterial: fixes #18439

merged 3 commits into from
Jan 21, 2020

Conversation

sunag
Copy link
Collaborator

@sunag sunag commented Jan 20, 2020 •
edited
Loading

  • Add anti-aliasing of @elalish
  • Fix NormalNode context
  • Update default StandardNodeMaterial values

Issue: #18360

@sunag sunag added this to the r113 milestone Jan 20, 2020
@sunag
Copy link
Collaborator Author

sunag commented Jan 20, 2020

@njarraud It fix your issue #18360?

@sunag
Copy link
Collaborator Author

sunag commented Jan 20, 2020

Exist a brightness difference of light in MeshStandardNodeMaterial to default material that I not fixed https://threejs.org/examples/webgl_materials_nodes.html

@mrdoob mrdoob merged commit d511f60 into mrdoob:dev Jan 21, 2020
@mrdoob
Copy link
Owner

mrdoob commented Jan 21, 2020

Thanks!

@njarraud
Copy link
Contributor

@njarraud It fix your issue #18360?

It looks like it does on the example from issue #18360
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r113
Development

Successfully merging this pull request may close these issues.
3 participants
@sunag @mrdoob @njarraud