Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core: rename .applyMatrix() to .applyMatrix4() #18449

Merged
merged 2 commits into from
Jan 23, 2020
Merged

Core: rename .applyMatrix() to .applyMatrix4() #18449

merged 2 commits into from
Jan 23, 2020

Conversation

WestLangley
Copy link
Collaborator

Following from the discussion in #18343, methods that take a matrix arg will now clearly identify the type of matrix.

I'll update the migration docs...

@WestLangley WestLangley added this to the r113 milestone Jan 22, 2020
@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 22, 2020

There seems to be much more example code that uses applyMatrix() but which is not migrated in this PR. Just one example:

three.js/examples/webgl_instancing_performance.html

Line 185 in cf28da9

instanceGeometry.applyMatrix( matrix );

A full text search 27 examples files using applyMatrix().

@WestLangley
Copy link
Collaborator Author

I am not going to update the examples in this PR. We need to ensure that all examples still function with the Legacy patch.

I updated .ts, docs/en, docs/zh, unit, Legacy, and DeprecatedList. I will update Migration and Examples if this is merged.

@WestLangley WestLangley merged commit 4587c92 into mrdoob:dev Jan 23, 2020
@WestLangley
Copy link
Collaborator Author

rebuild required... working on updating the examples...

@WestLangley WestLangley deleted the dev_rename_apply_matrix branch January 23, 2020 00:02
@mrdoob
Copy link
Owner

mrdoob commented Jan 23, 2020

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Jan 23, 2020

rebuild required...

Done!

@WestLangley WestLangley mentioned this pull request Jan 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r113
Development

Successfully merging this pull request may close these issues.
3 participants
@WestLangley @Mugen87 @mrdoob