-
-
Notifications
You must be signed in to change notification settings - Fork 35.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raycaster: Deprecate .linePrecision. #18648
Conversation
I ended-up pushing some tests. |
Please add this code to Three.Legacy.js, otherwise user code will break. Object.defineProperties( Raycaster.prototype, {
linePrecision: {
get: function () {
console.warn( 'THREE.Raycaster: .linePrecision has been deprecated. Use .params.Line.threshold instead.' );
return this.params.Line.threshold;
},
set: function ( value ) {
console.warn( 'THREE.Raycaster: .linePrecision has been deprecated. Use .params.Line.threshold instead.' );
this.params.Line.threshold = value;
}
}
} ); |
.linePrecision
(#18590)554c866
to
b30437b
Compare
No, not necessary. I've only changed the PR title since it makes my life easier when writing the release notes^^. |
@Mugen87 Understood. 😊 👍 Do you want me to squash the fixup commits and force-push the changes? I think GitHub allows you to see diffs between force-pushed changes (to verify I did not introduce new changes since your last review), but if you want to squash them yourself, I'll leave it to you. |
That would be great since the merge option |
@Mugen87 Done. 😊 |
Thanks! |
Fixes #18590.
There were no previous tests for Raycaster's precision/threshold, so I added none myself. 😅First PR in this project and very little experience with JS. Review with care... 😇